MaxGekk commented on a change in pull request #23727: [SPARK-26817][CORE] Use
System.nanoTime to measure time intervals
URL: https://github.com/apache/spark/pull/23727#discussion_r254527265
##########
File path:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala
##########
@@ -239,9 +239,9 @@ private[spark] class TorrentBroadcast[T: ClassTag](obj: T,
id: Long)
val estimatedTotalSize = Utils.bytesToString(numBlocks * blockSize)
logInfo(s"Started reading broadcast variable $id with $numBlocks
pieces " +
s"(estimated total size $estimatedTotalSize)")
- val startTimeMs = System.currentTimeMillis()
+ val startTime = System.nanoTime()
val blocks = readBlocks()
- logInfo("Reading broadcast variable " + id + " took" +
Utils.getUsedTimeMs(startTimeMs))
+ logInfo("Reading broadcast variable " + id + " took" +
Utils.getUsedTimeNs(startTime))
Review comment:
I will move the space from `getUsedTimeNs` to the original strings to not
confuse in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
