vanzin commented on a change in pull request #23599: [SPARK-24793][K8s] Enhance
spark-submit for app management
URL: https://github.com/apache/spark/pull/23599#discussion_r254864890
##########
File path:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
##########
@@ -304,18 +304,20 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
}
private def validateKillArguments(): Unit = {
- if (!master.startsWith("spark://") && !master.startsWith("mesos://")) {
- error("Killing submissions is only supported in standalone or Mesos
mode!")
+ if (!master.startsWith("spark://") && !master.startsWith("mesos://")
+ && !master.startsWith("k8s://")) {
Review comment:
This check goes against the plugin idea. Can it be removed? Seems like the
code that tries to load the new plugin handles this case already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
