HyukjinKwon commented on a change in pull request #23742: [SPARK-26835][DOCS] Documentationof Spark SQL Generic Load/Save Functions options extended URL: https://github.com/apache/spark/pull/23742#discussion_r255026383
########## File path: docs/sql-data-sources-load-save-functions.md ########## @@ -41,6 +41,11 @@ name (i.e., `org.apache.spark.sql.parquet`), but for built-in sources you can al names (`json`, `parquet`, `jdbc`, `orc`, `libsvm`, `csv`, `text`). DataFrames loaded from any data source type can be converted into other types using this syntax. +For built-in sources, the available extra options are documented in the API documentation, Review comment: vague but we shouldn't whitelist here for now. Otherwise, we should fix the documentation every time we add an API. Simply pointing out an API should be good enough for now. To permanently resolve the issue, we should find a way to deduplicate the doc and avoid maintenance overhead. If you're going to deal with this, please go ahead. For instance, libsvm is a builtin source but does not have `libsvm` method. Shall we avoid to whitelist here to avoid maintenance overhead? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
