srowen commented on a change in pull request #23743: [SPARK-26843][MESOS] Use
ConfigEntry for hardcoded configs for "mesos" resource manager
URL: https://github.com/apache/spark/pull/23743#discussion_r255080188
##########
File path:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
##########
@@ -34,11 +34,11 @@ import org.apache.spark.internal.Logging
*/
private[mesos] object MesosSchedulerBackendUtil extends Logging {
/**
- * Parse a comma-delimited list of volume specs, each of which
+ * Parse a list of volume specs, each of which
* takes the form [host-dir:]container-dir[:rw|:ro].
*/
- def parseVolumesSpec(volumes: String): List[Volume] = {
- volumes.split(",").map(_.split(":")).flatMap { spec =>
+ def parseVolumesSpec(volumes: Seq[String]): List[Volume] = {
Review comment:
Part of the purpose of these small comments, which can vary across
reviewers, is that it's a way for all of us to sync on how to handle the small
things.
The change to the method seems fine, and isn't part of any API. I don't
think it needs to be part of the title as it is in the description, even. Let's
conclude there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
