holdenk commented on a change in pull request #23741:
[SPARK-22798][PYTHON][ML]Add multiple column support to PySpark StringIndexer
URL: https://github.com/apache/spark/pull/23741#discussion_r255175683
##########
File path: python/pyspark/ml/feature.py
##########
@@ -2436,6 +2458,26 @@ def from_labels(cls, labels, inputCol, outputCol=None,
handleInvalid=None):
model.setHandleInvalid(handleInvalid)
return model
+ @classmethod
+ @since("3.0.0")
+ def from_ArrayOfLabels(cls, arrayOfLabels, inputCols, outputCols=None,
Review comment:
nit on naming: Perhaps `from_arrays_of_labels` since it's an array of arrays
of labels?
Coupled with the change down bellow I'd like to suggest we also test what
happens with the string indexer and different length arrays of labels? Just
it's possible the scala code could makes assumption about the lengths of the
arrays being fully populated which in this constructor might not be the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
