attilapiros commented on issue #23688: [SPARK-25035][Core] Avoiding memory mapping at disk-stored blocks replication URL: https://github.com/apache/spark/pull/23688#issuecomment-461946325 @vanzin I have moved the `lazy val` into the `save` method in the hope of improving on the abstraction. Moreover I am wondering weather a more explicit lazy construction would be bit better here (where the provided guarantees for concurrent usage are easier to follow). I have found two possible classes for the problem: - [LazyInitializer](https://commons.apache.org/proper/commons-lang/javadocs/api-3.1/org/apache/commons/lang3/concurrent/LazyInitializer.html) - [AtomicSafeInitializer](https://commons.apache.org/proper/commons-lang/javadocs/api-3.1/org/apache/commons/lang3/concurrent/AtomicSafeInitializer.html). What is your opinion?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
