srowen commented on issue #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter URL: https://github.com/apache/spark/pull/20793#issuecomment-461948879 For example, tests like this ... `org.scalatest.exceptions.TestFailedException: Expected 2.7115417862490827 and 2.7355261 to be within 0.001 using relative tolerance.` .. should just be resolved by increasing the tolerance, probably in all cases. We can review to be sure. But it's evidence that the (arbitrary) tolerance was too tight as a correct implementation might vary its result by more, depending on the random seed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
