GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/3660
Fix the initialization issue of 'codegenEnabled'
The problem is `codegenEnabled` is `val`, but it uses a `val` `sqlContext`,
which can be override by subclasses. Here is a simple example to show this
issue.
```Scala
scala> :paste
// Entering paste mode (ctrl-D to finish)
abstract class Foo {
protected val sqlContext = "Foo"
val codegenEnabled: Boolean = {
println(sqlContext) // it will call subclass's `sqlContext` which has
not yet been initialized.
if (sqlContext != null) {
true
} else {
false
}
}
}
class Bar extends Foo {
override val sqlContext = "Bar"
}
println(new Bar().codegenEnabled)
// Exiting paste mode, now interpreting.
null
false
defined class Foo
defined class Bar
```
To fix it, we should mark `codegenEnabled` as `lazy`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-4812
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3660.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3660
----
commit fab86585bcfbf1afaa300632faf259024facf66c
Author: zsxwing <[email protected]>
Date: 2014-12-10T07:25:54Z
Fix the initialization issue of 'codegenEnabled'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
