HyukjinKwon commented on a change in pull request #23746: [SPARK-26761][SQL][R]
Vectorized R gapply() and gapplyCollect() implementation
URL: https://github.com/apache/spark/pull/23746#discussion_r255371668
##########
File path: R/pkg/R/deserialize.R
##########
@@ -235,15 +235,18 @@ readDeserializeInArrow <- function(inputCon) {
# This is a hack to avoid CRAN check. Arrow is not uploaded into CRAN now.
See ARROW-3204.
requireNamespace1 <- requireNamespace
requireNamespace1("arrow", quietly = TRUE)
+ RecordBatchStreamReader <- get(
+ "RecordBatchStreamReader", envir = asNamespace("arrow"), inherits = FALSE)
+ as_tibble <- get("as_tibble", envir = asNamespace("arrow"))
Review comment:
Yes .. I actually tried to pull those out.. but I ended up with leave them
as are .. I target to remove those weird hacks as soon as Arrow is on CRAN
which I estimate before Spark 3.0. I promise I clean up those before Spark 3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
