cloud-fan commented on issue #23731: [SPARK-26572][SQL] fix aggregate codegen 
result evaluation
URL: https://github.com/apache/spark/pull/23731#issuecomment-462229877
 
 
   > The issue is that Broadcast join generates it's own loop. And without 
forcing evaluation of `resultExpressions` of `HashAggregateExec` before the 
join's loop these expressions can be executed multiple times giving incorrect 
results.
   
   Shouldn't we fix join instead of aggregate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to