cloud-fan commented on a change in pull request #23709:
[SPARK-26794][SQL]SparkSession enableHiveSupport does not point to hive but
in-memory while the SparkContext exists
URL: https://github.com/apache/spark/pull/23709#discussion_r255396424
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -39,8 +39,36 @@ import org.apache.spark.util.{MutableURLClassLoader, Utils}
/**
* A class that holds all state shared across sessions in a given
[[SQLContext]].
+ *
+ * @param sparkContext The Spark context associated with this SharedState
+ * @param initialConfigs The configs from the very first created SparkSession
*/
-private[sql] class SharedState(val sparkContext: SparkContext) extends Logging
{
+private[sql] class SharedState(
+ val sparkContext: SparkContext,
+ initialConfigs: scala.collection.Map[String, String])
+ extends Logging {
+
+ // This variable should be lazy, because in the first place we need to load
hive-site.xml into
+ // hadoopConf and determine the warehouse path which will be set into both
spark conf and hadoop
+ // conf avoiding be affected by any SparkSession level options
+ private lazy val (conf, hadoopConf) = {
Review comment:
shall we just move this code block after `val warehousePath: String ...`?
Then we don't need the lazy val.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
