HyukjinKwon commented on issue #23620: [SPARK-26696][SQL] Makes Dataset encoder public URL: https://github.com/apache/spark/pull/23620#issuecomment-462414789 > I am at a loss what about what more needs to happen for this one-line change... It's one-liner change but it is important since it exposes something as an API at `Dataset`. Here is quite a core API entry point. I myself already have few one-liner PRs that had to provide a lot of details. Adding or exposing new APIs in those is being discouraged IMHO in general. Let's be sure and clear about what API you're adding and why it's needed in particular for some core APIs. I know I am being a bit hysterical about it but my impression was that the purpose of this PR wasn't clear.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
