Github user akopich commented on the pull request:
https://github.com/apache/spark/pull/1269#issuecomment-66478011
Succeeded at the third attempt.
(5) Enumerator
@jkbradley, as you can see, I moved `Enumerator` to `mllib/features` folder
and renamed it to `TokenIndexer`. You said, I should write a setter method
`setRareTokenThreshold` -- I see no need in this due to the fact, that it's the
only one field. (If setter method is a code-style and/or API requirement, I'm
ready add it).
(6) move Dirichlet to stats
I like the idea to move Dirichlet pdf to stats for everyone to be able to
use it. But I see no classes computing pdf in mllib/stats folder, so I have no
idea what API should be implemented.
Any other remarks on code structure and/or API?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
