rdblue commented on a change in pull request #23606: [SPARK-26666][SQL] Support
DSv2 overwrite and dynamic partition overwrite.
URL: https://github.com/apache/spark/pull/23606#discussion_r255747755
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -365,16 +365,17 @@ case class Join(
}
/**
- * Append data to an existing table.
+ * Base trait for DataSourceV2 write commands
*/
-case class AppendData(
- table: NamedRelation,
- query: LogicalPlan,
- isByName: Boolean) extends LogicalPlan {
+trait V2WriteCommand extends Command {
+ def table: NamedRelation
+ def query: LogicalPlan
+
override def children: Seq[LogicalPlan] = Seq(query)
- override def output: Seq[Attribute] = Seq.empty
- override lazy val resolved: Boolean = {
+ override lazy val resolved: Boolean = writeResolved
+
+ def writeResolved: Boolean = {
Review comment:
Why?
When you ask for changes, please include your rationale so that I understand
the motivation and we can choose an appropriate solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
