squito commented on a change in pull request #23616: [SPARK-26688][YARN] Provide configuration of initially blacklisted YARN nodes URL: https://github.com/apache/spark/pull/23616#discussion_r255791034
########## File path: docs/running-on-yarn.md ########## @@ -462,6 +462,14 @@ To use a custom metrics.properties for the application master and executors, upd <code>spark.blacklist.application.maxFailedExecutorsPerNode</code>. </td> </tr> +<tr> + <td><code>spark.yarn.blacklist.initial.blacklisted.nodes</code></td> + <td>false</td> + <td> + Comma-separated list of strings used as initially blacklisted YARN nodes which stays always Review comment: oh yeah, the default is definitely not false, thanks for catching that. I also don't have much insight into a good name. I don't feel super strongly but I do prefer "spark.yarn" since its yarn-specific, for now, and also prefer something with "always" etc. over"initial", as you suggested. A bit weird having blacklisted twice, but eh, I don't really care that much. My preferences would be (1) "spark.yarn.exclude.nodes" (2) "spark.yarn.blacklist.always.blacklisted.nodes" (3) whatever else you want :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
