dongjoon-hyun commented on a change in pull request #23759: [SPARK-26840][SQL]
Avoid cost-based join reorder in presence of join hints
URL: https://github.com/apache/spark/pull/23759#discussion_r255819266
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
##########
@@ -43,10 +43,10 @@ object CostBasedJoinReorder extends Rule[LogicalPlan] with
PredicateHelper {
val result = plan transformDown {
// Start reordering with a joinable item, which is an InnerLike join
with conditions.
// Avoid reordering if a join hint is present.
- case j @ Join(_, _, _: InnerLike, Some(cond), hint) if hint ==
JoinHint.NONE =>
+ case j @ Join(_, _, _: InnerLike, Some(cond), JoinHint.NONE) =>
reorder(j, j.output)
- case p @ Project(projectList, Join(_, _, _: InnerLike, Some(cond),
hint))
- if projectList.forall(_.isInstanceOf[Attribute]) && hint ==
JoinHint.NONE =>
+ case p @ Project(projectList, Join(_, _, _: InnerLike, Some(cond),
JoinHint.NONE))
+ if projectList.forall(_.isInstanceOf[Attribute]) =>
Review comment:
Could you revert these aesthetic changes (line 46 ~ 49) back?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
