felixcheung commented on a change in pull request #23746: [SPARK-26761][SQL][R]
Vectorized R gapply() implementation
URL: https://github.com/apache/spark/pull/23746#discussion_r255837371
##########
File path: R/pkg/R/group.R
##########
@@ -229,6 +229,20 @@ gapplyInternal <- function(x, func, schema) {
if (is.character(schema)) {
schema <- structType(schema)
}
+ arrowEnabled <- sparkR.conf("spark.sql.execution.arrow.enabled")[[1]] ==
"true"
+ if (arrowEnabled) {
+ # Currenty Arrow optimization does not support raw for now.
+ # Also, it does not support explicit float type set by users.
+ if (inherits(schema, "structType")) {
Review comment:
the func signature is fairly loose here, so I think we need to handle the
case schema is not structType
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
