tgravescs commented on a change in pull request #23614: [SPARK-26689][CORE]Support blacklisting bad disk directory and retry in DiskBlockManager URL: https://github.com/apache/spark/pull/23614#discussion_r255957769
########## File path: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ########## @@ -48,32 +56,74 @@ private[spark] class DiskBlockManager(conf: SparkConf, deleteFilesOnStop: Boolea // of subDirs(i) is protected by the lock of subDirs(i) private val subDirs = Array.fill(localDirs.length)(new Array[File](subDirsPerLocalDir)) + private[spark] val badDirs = ArrayBuffer[File]() + private[spark] val dirToBlacklistExpiryTime = new HashMap[File, Long] + // Filename to dirId, it should be small enough to put into memory + private[spark] val migratedDirIdIndex = new ConcurrentHashMap[String, Int].asScala Review comment: comment could be more specific, just reading it without context I don't know what migrated means here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
