dongjoon-hyun commented on issue #23759: [SPARK-26840][SQL] Avoid cost-based join reorder in presence of join hints URL: https://github.com/apache/spark/pull/23759#issuecomment-462907132 ? > I did not suggest you review it again. I suggested you understand the logic first. Hey, @maryannxue . This is an open source project. > You probably should take a closer look at the logic :) If you said like the above, it causes another round of reviews. I understand your enthusiasm to contribute more. But, please take a step back and look at what happens after your SPARK-26065. 98be8953c7 [SPARK-26065][SQL] Change query hint from a `LogicalPlan` to a field 2d01bccbd4 [SPARK-26065][FOLLOW-UP][SQL] Fix the Failure when having two Consecutive Hints 985f966b9c [SPARK-26065][FOLLOW-UP][SQL] Revert hint behavior in join reordering ce7e7df99d [SPARK-26708][SQL] Incorrect result caused by inconsistency between a SQL cache's cached RDD and its physical plan [this PR](https://github.com/apache/spark/pull/23759). [SPARK-26840][SQL] Avoid cost-based join reorder in presence of join hints Are you 100% sure that there is no more bugs related to this? Until the branch becomes more stable back, please minimize the surface of changes by removing unnecessary refactoring. The unrelated refactoring really hurts the traceability.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
