HyukjinKwon commented on a change in pull request #23760: [SPARK-26762][SQL][R]
Arrow optimization for conversion from Spark DataFrame to R DataFrame
URL: https://github.com/apache/spark/pull/23760#discussion_r256306595
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1177,11 +1177,65 @@ setMethod("dim",
setMethod("collect",
signature(x = "SparkDataFrame"),
function(x, stringsAsFactors = FALSE) {
+ useArrow <- FALSE
Review comment:
Yes, in particular for such checking logics, I am going to write a helper
function and deduplicate all of them when I finish `dapply` which will be very
soon. Would it that make sense as well to you? If you think it should be done
here, I can do it here too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
