viirya commented on a change in pull request #23766: [SPARK-26859][SQL] Fix field writer index bug in non-vectorized ORC deserializer URL: https://github.com/apache/spark/pull/23766#discussion_r256321508
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/ReadSchemaSuite.scala ########## @@ -163,6 +168,7 @@ class VectorizedParquetReadSchemaSuite class MergedParquetReadSchemaSuite extends ReadSchemaSuite + with AddColumnIntoTheMiddleTest Review comment: If we want to add `AddColumnIntoTheMiddleTest` to all of above, maybe we can just let `ReadSchemaSuite` extend `AddColumnIntoTheMiddleTest`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
