vanzin commented on a change in pull request #23599: [SPARK-24793][K8s] Enhance
spark-submit for app management
URL: https://github.com/apache/spark/pull/23599#discussion_r256883190
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -1358,3 +1387,12 @@ private case class OptionAssigner(
deployMode: Int,
clOption: String = null,
confKey: String = null)
+
+private[spark] trait SparkSubmitOperationsClient {
+
+ def kill(args: SparkSubmitArguments): Unit
Review comment:
> it is possible to create a SparkConf from that argument map but then I
will need to filter out what is irrelevant,
Why would you filter out anything? We don't filter out Mesos-related configs
when submitting to YARN, for example. YARN just never looks at them.
Same thing here.
I just don't think `SparkSubmitArguments` is a good interface to expose to
code outside of `SparkSubmit`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
