falaki commented on a change in pull request #23760: [SPARK-26762][SQL][R]
Arrow optimization for conversion from Spark DataFrame to R DataFrame
URL: https://github.com/apache/spark/pull/23760#discussion_r257013632
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1177,11 +1177,67 @@ setMethod("dim",
setMethod("collect",
signature(x = "SparkDataFrame"),
function(x, stringsAsFactors = FALSE) {
+ connectionTimeout <-
as.numeric(Sys.getenv("SPARKR_BACKEND_CONNECTION_TIMEOUT", "6000"))
+ useArrow <- FALSE
+ arrowEnabled <-
sparkR.conf("spark.sql.execution.arrow.enabled")[[1]] == "true"
+ if (arrowEnabled) {
+ useArrow <- tryCatch({
+ requireNamespace1 <- requireNamespace
+ if (!requireNamespace1("arrow", quietly = TRUE)) {
+ stop("'arrow' package should be installed.")
+ }
+ # Currenty Arrow optimization does not support raw for now.
+ # Also, it does not support explicit float type set by users.
+ if (inherits(schema(x), "structType")) {
+ if (any(sapply(schema(x)$fields(),
Review comment:
Would be good to make this block shorter by moving some of the checking
logic into utility functions. This enables us to unit test these conditions
separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
