Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3672#discussion_r21663058
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -121,15 +127,28 @@ class HiveThriftServer2Suite extends FunSuite with
Logging {
val warehousePath = getTempFilePath("warehouse")
val metastorePath = getTempFilePath("metastore")
val metastoreJdbcUri =
s"jdbc:derby:;databaseName=$metastorePath;create=true"
+
val command =
- s"""$startScript
- | --master local
- | --hiveconf hive.root.logger=INFO,console
- | --hiveconf ${ConfVars.METASTORECONNECTURLKEY}=$metastoreJdbcUri
- | --hiveconf ${ConfVars.METASTOREWAREHOUSE}=$warehousePath
- | --hiveconf
${ConfVars.HIVE_SERVER2_THRIFT_BIND_HOST}=${"localhost"}
- | --hiveconf ${ConfVars.HIVE_SERVER2_THRIFT_PORT}=$port
- """.stripMargin.split("\\s+").toSeq
+ if (httpMode){
+ s"""$startScript
+ | --master local
+ | --hiveconf hive.root.logger=INFO,console
+ | --hiveconf
${ConfVars.METASTORECONNECTURLKEY}=$metastoreJdbcUri
+ | --hiveconf ${ConfVars.METASTOREWAREHOUSE}=$warehousePath
+ | --hiveconf
${ConfVars.HIVE_SERVER2_THRIFT_BIND_HOST}=${"localhost"}
+ | --hiveconf ${ConfVars.HIVE_SERVER2_TRANSPORT_MODE}=${"http"}
+ | --hiveconf ${ConfVars.HIVE_SERVER2_THRIFT_HTTP_PORT}=$port
+ """.stripMargin.split("\\s+").toSeq
+ } else {
+ s"""$startScript
+ | --master local
+ | --hiveconf hive.root.logger=INFO,console
+ | --hiveconf
${ConfVars.METASTORECONNECTURLKEY}=$metastoreJdbcUri
+ | --hiveconf ${ConfVars.METASTOREWAREHOUSE}=$warehousePath
+ | --hiveconf
${ConfVars.HIVE_SERVER2_THRIFT_BIND_HOST}=${"localhost"}
--- End diff --
Ah, I see, the original code uses a redundant `${...}` wrapper, please help
removing this one :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
