HyukjinKwon commented on a change in pull request #23787: [SPARK-26830][SQL][R]
Vectorized R dapply() implementation
URL: https://github.com/apache/spark/pull/23787#discussion_r257096052
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/r/ArrowRRunner.scala
##########
@@ -55,13 +56,32 @@ class ArrowRRunner(
numPartitions = -1,
isDataFrame = true,
schema.fieldNames,
- RRunnerModes.DATAFRAME_GAPPLY) {
+ mode) {
+
+ // TODO: it needs to refactor to share the same code with RRunner, and have
separate
+ // ArrowRRunners.
+ private val getNextBatch = {
Review comment:
I plan to clean this whole ArrowRRunner to deduplicate codes with RRunner
after this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
