Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3671#discussion_r21668908
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala 
---
    @@ -493,9 +493,9 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
       def leftOuterJoin[W](other: RDD[(K, W)], partitioner: Partitioner): 
RDD[(K, (V, Option[W]))] = {
         this.cogroup(other, partitioner).flatMapValues { pair =>
           if (pair._2.isEmpty) {
    -        pair._1.map(v => (v, None))
    +        pair._1.iterator.map(v => (v, None): (V, Option[W]))
    --- End diff --
    
    Interesting, are these types required? or can it be limited to just 
changing `None` to `None: Option[W]`?
    Not that it hurts to spell out the types.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to