vanzin commented on a change in pull request #23706: [SPARK-26790][CORE] Change
approach for retrieving executor logs and attributes: self-retrieve
URL: https://github.com/apache/spark/pull/23706#discussion_r257385246
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -225,19 +240,19 @@ private[spark] object CoarseGrainedExecutorBackend
extends Logging {
SparkHadoopUtil.get.addDelegationTokens(tokens, driverConf)
}
- val env = SparkEnv.createExecutorEnv(
- driverConf, executorId, hostname, cores, cfg.ioEncryptionKey, isLocal
= false)
+ val env = SparkEnv.createExecutorEnv(driverConf, arguments.executorId,
arguments.hostname,
+ arguments.cores, cfg.ioEncryptionKey, isLocal = false)
- env.rpcEnv.setupEndpoint("Executor", new CoarseGrainedExecutorBackend(
- env.rpcEnv, driverUrl, executorId, hostname, cores, userClassPath,
env))
- workerUrl.foreach { url =>
+ env.rpcEnv.setupEndpoint("Executor", backendCreateFn(env.rpcEnv,
arguments, env))
+ arguments.workerUrl.foreach { url =>
env.rpcEnv.setupEndpoint("WorkerWatcher", new
WorkerWatcher(env.rpcEnv, url))
}
env.rpcEnv.awaitTermination()
}
}
- def main(args: Array[String]) {
+ def parseArguments(args: Array[String], classNameForEntry: String)
+ : CoarseGrainedExecutorBackendArguments = {
Review comment:
Don't think of it as "2 spaces here, 4 spaces there". Think that method
declarations should stand about from the method body. And if you indent both
the same, that does not happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
