vanzin commented on issue #23801: [SPARK-26891][YARN] Fixing flaky test in YarnSchedulerBackendSuite URL: https://github.com/apache/spark/pull/23801#issuecomment-464250695 BTW this fix would be fine too except for one issue: each instantiation of `YarnSchedulerBackend` is creating a single thread pool that is not shutdown (since the test doesn't call `YarnSchedulerBackend.stop()`), and there will be a task scheduled on that thread pool for the duration of the test run (you can see a thread leak warning in the test logs). So your fix would be fine you also fix that problem by calling stop() in the tests, and updating the PR description to explain the underlying problem.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
