gatorsmile commented on a change in pull request #23259: [SPARK-26215][SQL] Define reserved/non-reserved keywords based on the ANSI SQL standard URL: https://github.com/apache/spark/pull/23259#discussion_r257483782
########## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ########## @@ -1014,6 +1035,25 @@ OPTION: 'OPTION'; ANTI: 'ANTI'; LOCAL: 'LOCAL'; INPATH: 'INPATH'; +AUTHORIZATION: 'AUTHORIZATION'; +CHECK: 'CHECK'; Review comment: When ansi is off, we need to ensure all these newly added keywords are still not reserved. Thus, `CHECK` should be added to `nonReserved `, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
