maropu commented on a change in pull request #23750: [SPARK-19712][SQL] Pushing
Left Semi and Left Anti joins through Project, Aggregate, Window, Union etc.
URL: https://github.com/apache/spark/pull/23750#discussion_r257502612
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1131,7 +1121,25 @@ object PushDownPredicate extends Rule[LogicalPlan] with
PredicateHelper {
}
}
- private def canPushThrough(p: UnaryNode): Boolean = p match {
+
+ def getAliasMap(plan: LogicalPlan): AttributeMap[Expression] = {
Review comment:
nit: How about splitting this function into pieces like `getAliasMap(p:
Project)` and `getAliasMap(agg: Aggregate)`? I a bit worry that other
developers wrongly use this function like `getAliasMap(non-project/aggregate
plan)` and this throws an unmatched exception....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
