srowen commented on a change in pull request #23811: [SPARK-26902][SQL] Support
java.time.Instant as an external type of TimestampType
URL: https://github.com/apache/spark/pull/23811#discussion_r257517630
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1659,6 +1659,12 @@ object SQLConf {
"a SparkConf entry.")
.booleanConf
.createWithDefault(true)
+
+ val TIMESTAMP_EXTERNAL_TYPE = buildConf("spark.sql.catalyst.timestampType")
Review comment:
Import is fine; we could potentially read both types to TimestampType. Can
we just be opinionated about the right way to write it back out, and keep
current behavior? it may be 'legacy' but not sure it's worth the behavior
change. You may have more context on why that's important though.
As with many things I just don't know how realistically people will
understand the issue, find the flag, set it, and maintain it across deployments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
