jiangxb1987 commented on a change in pull request #23820:
[SPARK-22860][CORE][YARN] Redact command line arguments for running Driver and
Executor before logging (standalone and YARN)
URL: https://github.com/apache/spark/pull/23820#discussion_r257722583
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2617,6 +2617,22 @@ private[spark] object Utils extends Logging {
redact(redactionPattern, kvs.toArray)
}
+ def redactCommandLineArgs(conf: SparkConf, commands: Seq[String]):
Seq[String] = {
+ val redactionPattern = conf.get(SECRET_REDACTION_PATTERN)
+ commands.map { cmd =>
+ var newCmd = cmd
Review comment:
Seems we shall only match the pattern "-D$key=$value" here, otherwise return
the original cmd. That way the code may be simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
