HeartSaVioR commented on a change in pull request #23822: [MINOR][DOC] Add note 
regarding proper usage of QueryExecution.toRdd
URL: https://github.com/apache/spark/pull/23822#discussion_r257830704
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
 ##########
 @@ -92,6 +92,8 @@ class QueryExecution(
    * accessing after iteration. (Calling `collect()` is one of known bad 
usage.)
    * If you want to store these rows into collection, please apply some 
converter or copy row
    * which produces new object per iteration.
+   * Given QueryExecution is not a public class, end users are discouraged to 
use this: please
+   * user `Dataset.rdd` instead which conversion will be applied.
 
 Review comment:
   Nice finding. Applied.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to