viirya commented on a change in pull request #23741:
[SPARK-22798][PYTHON][ML]Add multiple column support to PySpark StringIndexer
URL: https://github.com/apache/spark/pull/23741#discussion_r257929788
##########
File path: python/pyspark/ml/wrapper.py
##########
@@ -71,6 +71,9 @@ def _new_java_array(pylist, java_class):
"""
Create a Java array of given java_class type. Useful for
calling a method with a Scala Array from Python with Py4J.
+ If the param pylist is a 2D array, then a 2D java array will be
returned.
+ The returned 2D java array is a square, non-jagged 2D array that is big
+ enough for all elements.
Review comment:
The slots in the inner Java arrays will be filled with null to make the
non-jagged 2D array. I feel that it is better to mention it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
