Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3395#discussion_r21728943
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ---
@@ -80,8 +80,11 @@ class JoinSuite extends QueryTest with
BeforeAndAfterEach {
classOf[HashOuterJoin]),
("SELECT * FROM testData right join testData2 ON key = a and key =
2",
classOf[HashOuterJoin]),
- ("SELECT * FROM testData full outer join testData2 ON key = a",
classOf[HashOuterJoin])
- // TODO add BroadcastNestedLoopJoin
+ ("SELECT * FROM testData full outer join testData2 ON key = a",
classOf[HashOuterJoin]),
+ ("SELECT * FROM testData left JOIN testData2 ON (key*a != key+a)",
classOf[BroadcastNestedLoopJoin]),
+ ("SELECT * FROM testData right JOIN testData2 ON (key*a != key+a)",
classOf[BroadcastNestedLoopJoin]),
+ ("SELECT * FROM testData full JOIN testData2 ON (key*a != key+a)",
classOf[BroadcastNestedLoopJoin])
+
--- End diff --
Remove this line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
