HeartSaVioR commented on a change in pull request #23835:
[SPARK-24783][SQL]spark.sql.shuffle.partitions=0 should throw exception
URL: https://github.com/apache/spark/pull/23835#discussion_r258201168
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -267,6 +267,7 @@ object SQLConf {
"Note: For structured streaming, this configuration cannot be changed
between query " +
"restarts from the same checkpoint location.")
.intConf
+// .checkValue(_ > 0, "the value of sql.shuffle.partitions must be greater
than 0")
Review comment:
`Adding tests which reproduces a bug` meant adding tests which fail when we
don't apply this patch and passes when we apply this patch. So if you confirmed
it, you can uncomment and let tests pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
