vanzin commented on issue #23793: [SPARK-24736][k8s] Let spark-submit handle 
dependency resolution.
URL: https://github.com/apache/spark/pull/23793#issuecomment-465284155
 
 
   I re-ran all my previous tests on master and with my change, and also added 
the same tests with a zip dependency, and turns out the behavior is exactly the 
same on both. The difference is that this PR gets rid of a bunch of code, and 
you also get a clean "PYTHONPATH" (with master, you get the "http://"; URI 
verbatim in the value of that env variable).
   
   So, IMO, still a net gain, and we can fix the remaining local: and .zip 
issues separately, benefiting everybody, not just k8s.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to