seancxmao opened a new pull request #23844: [SPARK-26939][CORE][DOC] Fix some 
outdated comments about task schedulers
URL: https://github.com/apache/spark/pull/23844
 
 
   ## What changes were proposed in this pull request?
   This PR aims to fix some outdated comments about task schedulers.
   
   1. Remove below comments from `TaskScheduler`
   
   > currently implemented exclusively by 
`org.apache.spark.scheduler.TaskSchedulerImpl`
   
   Given the current class hierarchy below, `TaskSchedulerImpl` is not the only 
implementing class as of now, though it is the only direct subclass.
   
   ```
   org.apache.spark.scheduler.TaskScheduler
   |- org.apache.spark.scheduler.TaskSchedulerImpl
      |- org.apache.spark.scheduler.cluster.YarnScheduler
         |- org.apache.spark.scheduler.cluster.YarnClusterScheduler
   ```
   
   2. Change "ClusterScheduler" to "YarnScheduler" in comments of 
`YarnClusterScheduler`
   
   According to [SPARK-1140 Remove references to 
ClusterScheduler](https://issues.apache.org/jira/browse/SPARK-1140), 
ClusterScheduler is not used anymore.
   
   I also searched "ClusterScheduler" within the whole project, no other 
occurrences are found in comments or test cases. Note classes like 
`YarnClusterSchedulerBackend` or `MesosClusterScheduler` are not relevant.
   
   3. Remove comments about `statusUpdate` from `TaskSetManager`
   `statusUpdate` has been moved to TaskSchedulerImpl.
   
   ## How was this patch tested?
   N/A. Fix comments only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to