peter-toth edited a comment on issue #23802: [SPARK-26893][SQL] Allow partition 
pruning with subquery filters on file source
URL: https://github.com/apache/spark/pull/23802#issuecomment-465520513
 
 
   > does it really help with performance? The `HiveShim#convertFilters` 
doesn't support subquery filter either, so partition pruning can't get the 
benefit of it.
   
   ~~Hmm, I don't see in `HiveTableScans` strategy that it filters out subquery 
expressions from partition pruning filters (`pruningPredicates`) before passing 
it to `HiveTableScanExec` and then to `HiveShim#convertFilters`. Nor I see that 
it includes these filters in `FilterExec` around `HiveTableScanExec`. Seems 
like a bug to me.~~
   
   Never mind. I get it now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to