manuzhang commented on a change in pull request #3497: SPARK-4170 [CORE]
Closure problems when running Scala app that "extends App"
URL: https://github.com/apache/spark/pull/3497#discussion_r258490540
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -345,6 +345,11 @@ object SparkSubmit {
System.exit(CLASS_NOT_FOUND_EXIT_STATUS)
}
+ // SPARK-4170
+ if (classOf[scala.App].isAssignableFrom(mainClass)) {
Review comment:
I mean user's application like
```scala
object Test extends App {
// spark code
}
```
In this case, `mainClass` is `Test` and
`classOf[scala.App].isAssignableFrom(Test)` would be false since it's `Test$`
that extends `scala.App`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
