srowen commented on a change in pull request #3497: SPARK-4170 [CORE] Closure
problems when running Scala app that "extends App"
URL: https://github.com/apache/spark/pull/3497#discussion_r258531795
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -345,6 +345,11 @@ object SparkSubmit {
System.exit(CLASS_NOT_FOUND_EXIT_STATUS)
}
+ // SPARK-4170
+ if (classOf[scala.App].isAssignableFrom(mainClass)) {
Review comment:
Hm, OK, what happens if you have `class Test extends App`?
In any event, if we do need to check both `Test` and `Test$`, that's fine,
that's an easy change. I'd open a follow-up minor JIRA and make the change as a
PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
