jiangxb1987 commented on a change in pull request #23844: [SPARK-26939][CORE][DOC] Fix some outdated comments about task schedulers URL: https://github.com/apache/spark/pull/23844#discussion_r258538770
########## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ########## @@ -36,9 +36,8 @@ import org.apache.spark.util.collection.MedianHeap /** * Schedules the tasks within a single TaskSet in the TaskSchedulerImpl. This class keeps track of * each task, retries tasks if they fail (up to a limited number of times), and - * handles locality-aware scheduling for this TaskSet via delay scheduling. The main interfaces - * to it are resourceOffer, which asks the TaskSet whether it wants to run a task on one node, - * and statusUpdate, which tells it that one of its tasks changed state (e.g. finished). + * handles locality-aware scheduling for this TaskSet via delay scheduling. The main interface + * to it is resourceOffer, which asks the TaskSet whether it wants to run a task on one node. Review comment: Do you want to mention the `handleSuccessfulTask/handleFailedTask` functions? Actually I don't think this is a big deal since they are still triggered by StatusUpdate. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
