pgandhi999 commented on a change in pull request #22806: [SPARK-25250][CORE] :
Late zombie task completions handled correctly even before new taskset launched
URL: https://github.com/apache/spark/pull/22806#discussion_r258674729
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1383,6 +1383,7 @@ private[spark] class DAGScheduler(
event.reason match {
case Success =>
+ taskScheduler.markPartitionCompletedFromEventLoop(task.partitionId,
task.stageId)
Review comment:
The method `handleFailedTask` is called from TaskResultGetter to
TaskSchedulerImpl which executes the call to TaskSetManager in synchronized
block. So, my code in TaskSetManager runs within the TaskSchedulerImpl lock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
