MichaelChirico commented on issue #23823: [R] Add explicit UTF-8 Encoding to DESCRIPTION URL: https://github.com/apache/spark/pull/23823#issuecomment-465815401 I'm not quite sure I follow, is this correct: - `roxygen2` requires `Encoding: UTF-8` only since v6.0.1.9000 (commit [here](https://github.com/klutometis/roxygen/commit/7887556fd62678df5cb26454f0754fec91437221)) - `RoxygenNote` on `SparkR` is only 5.0.1 - `Spark` (and by extension `SparkR`) is tested only in an ASCII environment, with no plans to change at the moment Therefore: - Leave `DESCRIPTION` unchanged - Add a note to `DOCUMENTATION.md` advising that you can ignore the `warning` if you're using a more recent version of `roxygen2` - Perhaps file a JIRA recording this, with a note to add `Encoding: UTF-8` in case the test environment is ever upgraded?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
