HyukjinKwon commented on a change in pull request #23835:
[SPARK-24783][SQL]spark.sql.shuffle.partitions=0 should throw exception
URL: https://github.com/apache/spark/pull/23835#discussion_r258757477
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
##########
@@ -969,4 +969,9 @@ class JoinSuite extends QueryTest with SharedSQLContext {
Seq(Row(0.0d, 0.0/0.0)))))
}
}
+
+ test("[SPARK-24783][SQL]spark.sql.shuffle.partitions=0 should throw
exception ") {
+ val e =
intercept[IllegalArgumentException](withSQLConf("spark.sql.shuffle.partitions"
-> "0"){})
+ assert(e.getMessage.contains("the value of sql.shuffle.partitions must
be greater than 0"))
+ }
Review comment:
I think you can also move the test into
https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
