srowen commented on a change in pull request #23815: [SPARK-26908][SQL] Fix
DateTimeUtils.toMillis and millisToDays
URL: https://github.com/apache/spark/pull/23815#discussion_r258967819
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -541,4 +542,10 @@ class DateTimeUtilsSuite extends SparkFunSuite {
}
}
}
+
+ test("toMillis") {
+ val input = -9223372036844776001L
+ val expected = -9223372036844777L
+ assert(DateTimeUtils.toMillis(input) == expected, s"input = ${input}")
Review comment:
You don't need to provide a message; if you use `===` it will print a useful
message if it fails. How about adding the test from the comment in line 185
above?
If you want to finish up the TODO this is looking good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
