dongjoon-hyun commented on issue #23851: [SPARK-26950][SQL][TEST] Make 
RandomDataGenerator use Float.NaN or Double.NaN for all NaN values
URL: https://github.com/apache/spark/pull/23851#issuecomment-466104618
 
 
   Thank you for review, @cloud-fan and @srowen .
   
   To @cloud-fan .
   `checkEvaluationWithUnsafeProjection` should handle more complex expressions 
like `from_avro(to_avro([NaN]), 
{"type":"record","name":"topLevelRecord","fields":[{"name":"col_1","type":["float","null"]}]})`
 described in the PR description. However,
   
   1. `NormalizeNaNAndZero` expects and handles `Float` and `Double` instances 
only.
   2. `NormalizeFloatingNumbers` expects `Plan`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to