Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3409#discussion_r21763504
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala
---
@@ -352,12 +352,28 @@ private[spark] trait ClientBase extends Logging {
if (isLaunchingDriver) {
sparkConf.getOption("spark.driver.extraJavaOptions")
.orElse(sys.env.get("SPARK_JAVA_OPTS"))
+ .map(Utils.splitCommandString).getOrElse(Seq.empty)
.foreach(opts => javaOpts += opts)
val libraryPaths =
Seq(sys.props.get("spark.driver.extraLibraryPath"),
sys.props.get("spark.driver.libraryPath")).flatten
if (libraryPaths.nonEmpty) {
prefixEnv = Some(Utils.libraryPathEnvPrefix(libraryPaths))
--- End diff --
by the way we should log a warning or something if the we're in this case
and we detect `spark.yarn.am.extraJavaOptions`, since that won't actually take
effect. @tgravescs do you think it's better to log the warning or fail fast by
throwing an exception here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
