HeartSaVioR commented on issue #23850: [SPARK-26949][SS] Prevent 'purge' to remove needed batch files in CompactibleFileStreamLog URL: https://github.com/apache/spark/pull/23850#issuecomment-466173672 Thanks @gaborgsomogyi for providing your opinion. Same here, and that's why I took this approach and left such approaches as alternatives. > If it would be really required I think the compacted file can be deserialized => remove the batches => serialized again with proper content (maybe you meant the same by `maintain logs`). What I meant by `maintain logs` is compaction what CompactibleFileStreamLog is doing now. IMHO instrumenting latest compacted batch doesn't seem to be an alternative, because we can't find which entries were added before thresholdBatchId once batches were compacted.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
