bersprockets commented on a change in pull request #23768: [SPARK-26851][SQL]
Fix double-checked locking in CachedRDDBuilder
URL: https://github.com/apache/spark/pull/23768#discussion_r259126436
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
##########
@@ -49,7 +49,7 @@ case class CachedRDDBuilder(
storageLevel: StorageLevel,
@transient cachedPlan: SparkPlan,
tableName: Option[String])(
- @transient private var _cachedColumnBuffers: RDD[CachedBatch] = null) {
+ @transient @volatile private var _cachedColumnBuffers: RDD[CachedBatch] =
null) {
Review comment:
Thanks @srowen . Going forward, I assume I (and other contributors) should
be building at least once with ```-Pscala-2.11``` before submitting or updating
a PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
